-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCI join method - Add client auth ceremony #51445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
reviewed
Jan 28, 2025
e353656
to
acaf9c2
Compare
nklaassen
approved these changes
Jan 29, 2025
9e12491
to
3323789
Compare
acaf9c2
to
6ad2308
Compare
6ad2308
to
21128b0
Compare
strideynet
approved these changes
Jan 30, 2025
bl-nero
reviewed
Jan 30, 2025
rosstimothy
reviewed
Jan 31, 2025
rosstimothy
approved these changes
Feb 3, 2025
lib/auth/join/oracle/oracle.go
Outdated
return string(canonicalRegion), realm | ||
} | ||
|
||
var ociRealms = []string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The realm lookup could be constant time instead of linear if this was a set
Suggested change
var ociRealms = []string{ | |
var ociRealms = map[string]struct{}{ |
This change adds the client side of the auth ceremony for the Oracle join method.
d647b43
to
db0511e
Compare
atburke
added a commit
that referenced
this pull request
Feb 7, 2025
This change adds the client side of the auth ceremony for the Oracle join method.
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
This change adds the client side of the auth ceremony for the Oracle join method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the client side of the auth ceremony for the Oracle join method (RFD).
Part of #41705.
Follows #51444.