Ignore ~/.tsh/environment file if it does not exist. #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fa7d85 to
9a72243
Compare
kontsevoy
reviewed
Jun 5, 2017
lib/utils/environment.go
Outdated
| file, err := os.Open(filename) | ||
| if err != nil { | ||
| return nil, trace.ConvertSystemError(err) | ||
| err = trace.ConvertSystemError(err) |
There was a problem hiding this comment.
This error, no matter what kind, should be printed into stderror but the login process should not terminate just because environment file is (for whatever reason) not accessible.
9a72243 to
26a565e
Compare
|
LGTM |
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
At the moment if you specify the
--permit-user-envflag it requires the user have a~/.tsh/environmentfile. This PR changes this behavior by making this file optional.Implementation
~/.tsh/environmentwas not found, if it wan't found, return an empty slice.Related Issues
Fixes #1035