Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart UI invalid username #4008

Closed
benarent opened this issue Jul 9, 2020 · 4 comments · Fixed by gravitational/webapps#123
Closed

Quickstart UI invalid username #4008

benarent opened this issue Jul 9, 2020 · 4 comments · Fixed by gravitational/webapps#123
Assignees
@kimlisa
Milestone
4.3.1 "Londinium"

Comments

@benarent
Copy link
Contributor

benarent commented Jul 9, 2020

Description

What happened:
Quick launch doesn't account a . in the username. e.g. ben.arent@host

image

What you expected to happen:
Within reason, we should let customers input. Within the limits of linux username, e.g. a Ec2 instance allows a username with up to 256 characters.

How to reproduce it (as minimally and precisely as possible):

Environment

  • Teleport version (use teleport version): 4.3.0
@benarent benarent added the hornet label Jul 9, 2020
@benarent benarent added this to the 4.4 "Rome" milestone Jul 9, 2020
@webvictim
Copy link
Contributor

We should fix this in 4.3.1. The regex was already changed to allow - in an early 4.3.0 alpha.

@benarent
Copy link
Contributor Author

We should also consider this PR #4002

@kimlisa kimlisa self-assigned this Jul 11, 2020
@alex-kovoy
Copy link
Contributor

@kimlisa lets simplify that validation rule by checking

  1. if not empty
  2. if no spaces.

@kimlisa kimlisa mentioned this issue Jul 14, 2020
Merged
@russjones
Copy link
Contributor

russjones commented Jul 15, 2020 •
edited
Loading

Best: 1
Realistic: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimlisa kimlisa

Labels
None yet
Projects
None yet
Milestone
4.3.1 "Londinium"
Development

Successfully merging a pull request may close this issue.

Lisa/minor fixes gravitational/webapps
5 participants
@benarent @webvictim @russjones @alex-kovoy @kimlisa