Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsh login timeout too aggressive, not configurable #2483

Closed
aberoham opened this issue Jan 11, 2019 · 2 comments
Closed

tsh login timeout too aggressive, not configurable #2483

aberoham opened this issue Jan 11, 2019 · 2 comments
Assignees

Comments

@aberoham
Copy link
Contributor

What happened:

tsh login timeout for SAML/OIDC is too quick for some scenarios, such as when the identity provider has non-immediate additional auth factors (such as email-based tokens).

If browser window does not open automatically, open it by clicking on the link:
 http://127.0.0.1:54679/[redacted]
error: timed out waiting for callback

What you expected to happen: For SAML/OIDC timeout to be configurable or simply longer than the current 60 second value

How to reproduce it (as minimally and precisely as possible): Run tsh login against an auth provider you're not currently logged into and wait 60+ seconds.

Environment:

  • Teleport version (use teleport version): 3.x
  • Tsh version (use tsh version): 3.x
  • OS (e.g. from /etc/os-release): n/a

Browser environment
n/a

Relevant Debug Logs If Applicable

n/a

@kontsevoy kontsevoy added this to the 3.1.6 "West Village" milestone Jan 29, 2019
@kontsevoy
Copy link
Contributor

@klizhentas need your opinion on this, especially about simply increasing the default value to, say, 180 seconds.

@klizhentas
Copy link
Contributor

sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants