User Environment Regression

[russjones]

Issue

If you use the --permit-user-env flag and do not specify a ~/.tsh/environment file, tsh does not allow you to login.

$ ./tsh --proxy=localhost --user=rjones ssh localhost
Enter password for Teleport user rjones:

ERROR REPORT:
Original Error: *trace.NotFoundError open /Users/rjones/.tsh/environment: no such file or directory
Stack Trace:
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/utils/environment.go:20 github.com/gravitational/teleport/lib/utils.ReadEnvironmentFile
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/srv/exec.go:284 github.com/gravitational/teleport/lib/srv.prepareCommand
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/srv/exec.go:132 github.com/gravitational/teleport/lib/srv.prepInteractiveCommand
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/srv/sess.go:530 github.com/gravitational/teleport/lib/srv.(*session).start
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/srv/sess.go:120 github.com/gravitational/teleport/lib/srv.(*sessionRegistry).openSession
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/srv/sshserver.go:903 github.com/gravitational/teleport/lib/srv.(*Server).dispatch
	/Users/rjones/Development/go/src/github.com/gravitational/teleport/lib/srv/sshserver.go:850 github.com/gravitational/teleport/lib/srv.(*Server).handleSessionRequests
	/usr/local/go/src/runtime/asm_amd64.s:2198 runtime.goexit
User Message: open /Users/rjones/.tsh/environment: no such file or directory
ssh: could not start shell

Solution

If ~/.tsh/environment is not found, tsh should ignore the file and move on as setting --permit-user-env allows you to specify an environment file, it doesn't not require you have one.