Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any documentation about becoming dependency free? #2380

Closed
grug opened this issue Jan 21, 2020 · 2 comments
Closed

Any documentation about becoming dependency free? #2380

grug opened this issue Jan 21, 2020 · 2 comments
Labels

Comments

@grug
Copy link

grug commented Jan 21, 2020

Hey there - big fan of the library and a big fan of the fact there are zero dependencies in the project. I was just wondering if there is any documentation/blog posts etc... I can read about the strategies taken to remove all the dependencies from the project? I'm just really interested in the strategies and lessons learned from this effort that I could apply to my own projects :)

Thanks
-Dave

@IvanGoncharov
Copy link
Member

@grug Thanks for the interest 👍
Actually, This library was dependency-free until iterall dependency was introduced almost 4 years ago:
03f06e9#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
So it's not a very exciting story: I just removed iterall that's it 🤷‍♂️

In general, graphql-js is a reference implementation that means it should be easily portable to other languages so we can't depend on any 3rd-party library.
iterall was special in a sense it's more a polyfill than a library but since it started to cause issues with ESM build I just removed it.

Did I answer your question?

@grug
Copy link
Author

grug commented Jan 21, 2020

Hey Ivan - thanks so much for getting back to me about this so quickly.

That's very cool! That does indeed answer my question :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants