Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy preview issues from forked branches? #2004

Closed
acao opened this issue Nov 5, 2021 · 2 comments
Closed

deploy preview issues from forked branches? #2004

acao opened this issue Nov 5, 2021 · 2 comments

Comments

@acao
Copy link
Member

acao commented Nov 5, 2021

I think when a branch is from a fork, deploy previews are not appearing, perhaps?

maybe related to our choice of github actions on clause types: [opened, synchronize]

#1988 is a great example of this

@acao acao changed the title deploy preview issues? deploy preview issues from forked branches? Nov 5, 2021
@acao
Copy link
Member Author

acao commented Nov 5, 2021

the main reason I moved to this deploy previews pattern is because I didn't want to use up all the build minutes on the shared graphql foundation netlify plan also used by graphql.org and swapi-graphql, but we do use up a ton of netlify bandwith

@acao
Copy link
Member Author

acao commented Nov 24, 2021

we will need to move back to netlify builds I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant