Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.8.0 needs graphql@15.5.0 (?) #293

Closed
eddeee888 opened this issue Feb 3, 2021 · 4 comments
Closed

Version 0.8.0 needs graphql@15.5.0 (?) #293

eddeee888 opened this issue Feb 3, 2021 · 4 comments

Comments

@eddeee888
Copy link
Contributor

eddeee888 commented Feb 3, 2021

Bug description

Version 0.8.0 comes with this commit: 2f6313b which depends on the rules to be in the graphql package. However, the rules have only been renamed to have Rule suffix in this PR: graphql/graphql-js#2402 which is graphql@15.0.0

As a result, when I tried to run graphql-eslint with graphql@14.6.0, it failed because the rule file name is different.

Bumping to graphql@15.5.0 solved this issue for me.

Suggestions

Maybe we can update the peerDependencies to reflect this? ( I think that's what it's for right? )
Or maybe we could revert the commit that sets external rules for now? :)

@dotansimha
Copy link
Member

Hi @eddeee888
Tracking this in #292
It was a mistake, we fixed a bundling issue in the package, and now the graphql-js validation rules comes from node_modules, leading to an error in case of a new version of graphql.
Working on a fix :)

@dotansimha
Copy link
Member

I tried to fix that in #298 . can you please try the alpha version? @graphql-eslint/eslint-plugin@0.8.1-alpha-7440aa7.0

@eddeee888
Copy link
Contributor Author

eddeee888 commented Feb 4, 2021

The alpha version is working on my end. Cheers! 🎉

@dotansimha
Copy link
Member

Fixed in @graphql-eslint/eslint-plugin@0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants