Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog missing for v4.0.0 #319

Closed
gavinhenderson opened this issue Feb 1, 2022 · 6 comments
Closed

Changelog missing for v4.0.0 #319

gavinhenderson opened this issue Feb 1, 2022 · 6 comments

Comments

@gavinhenderson
Copy link

Thanks for all your hard-work on graphql-request, it is much appreciated.

Is there any plans to issue a change log for v4.0.0? Without one I can't be certain what breaking changes it contains, therefore can't confidently upgrade to the latest version.

@arminrosu
Copy link

For reference, this is the diff provided by renovate-bot: https://app.renovatebot.com/package-diff?name=graphql-request&from=3.7.0&to=4.0.0

Considering 4.0.0 was released 4 days ago, this should be the git diff: 3.7.0...12c2e8d, ie. PR #303

@jasonkuhrt
Copy link
Member

There's problems with the release tool at the moment. The desire to certainly to have change logs. Commit messages are generally well used and should be usable meanwhile.

@lensbart
Copy link

Reading the commit messages doesn’t make this immediately clear — are there any breaking changes since 3.7.0?

Thanks

@jasonkuhrt
Copy link
Member

This is marked as a breaking change but not sure why, on mobile right now.

12c2e8d

@thegiantbeast
Copy link

@jasonkuhrt can you tell me what the breaking change is?

I only see a new feature being added from the commit you shared (cancellation), not changing a previous behaviour, but I could be wrong.

@jasonkuhrt
Copy link
Member

I looked again, it seems that official support for Node.js 12 was dropped. Manually noting this in the changelog now:

https://github.com/prisma-labs/graphql-request/releases/tag/4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants