From 5b5f2d4196c35a5452edfb4f642dadd20981786c Mon Sep 17 00:00:00 2001 From: Ruslan Gainanov Date: Fri, 18 Nov 2022 15:52:11 +0300 Subject: [PATCH 1/3] fix existingSecret to default value (see #761) --- helm/oncall/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helm/oncall/values.yaml b/helm/oncall/values.yaml index 3de0e12225..ed23775930 100644 --- a/helm/oncall/values.yaml +++ b/helm/oncall/values.yaml @@ -242,7 +242,7 @@ externalRabbitmq: # use an existing secret for the rabbitmq password existingSecret: "" # the key in the secret containing the rabbitmq password - passwordKey: password + passwordKey: "" # the key in the secret containing the rabbitmq username usernameKey: username From 6b8b05b2723044dbde6fdb42c38e272a81d094bf Mon Sep 17 00:00:00 2001 From: Ildar Iskhakov Date: Tue, 13 Jun 2023 11:36:54 +0800 Subject: [PATCH 2/3] Use default key in test when using external secret --- helm/oncall/tests/rabbitmq_env_test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helm/oncall/tests/rabbitmq_env_test.yaml b/helm/oncall/tests/rabbitmq_env_test.yaml index 438d2d4508..a969ccd48e 100644 --- a/helm/oncall/tests/rabbitmq_env_test.yaml +++ b/helm/oncall/tests/rabbitmq_env_test.yaml @@ -177,7 +177,7 @@ tests: name: RABBITMQ_PASSWORD valueFrom: secretKeyRef: - key: password + key: rabbitmq-password name: oncall-rabbitmq-external - containsDocument: kind: Secret From 4cbdfab78feec1a39dbdbd27bdafc3bf0daa4bf5 Mon Sep 17 00:00:00 2001 From: Ildar Iskhakov Date: Tue, 13 Jun 2023 12:59:04 +0800 Subject: [PATCH 3/3] Add changelog --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ec0d04ea1..4f6b1c9a3b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## Unreleased + +### Changed + +- Change .Values.externalRabbitmq.passwordKey from `password` to `""` (default value `rabbitmq-password`) [864](https://github.com/grafana/oncall/pull/864) + ## v1.2.43 (2023-06-12) ### Changed