Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users downgrading permissions not considered part of schedule #524

Open
mderynck opened this issue Sep 12, 2022 · 3 comments
Open

Users downgrading permissions not considered part of schedule #524

mderynck opened this issue Sep 12, 2022 · 3 comments
Labels
needs triage pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action

Comments

@mderynck
Copy link
Contributor

If a user is referenced by a schedule and their role gets set back to viewer they are no longer considered for notification as part of the schedule and the schedule will have a gap. What can be done in this case to make sure notifications are not missed if the schedule is not updated or the permission corrected immediately?

@Matvey-Kuk
Copy link
Contributor

@mderynck for me sounds like a bug. May be let's allow "Viewer" to be on-call in the schedule?

@mderynck
Copy link
Contributor Author

The permission applies even without a schedule so in a simple case of direct notification we get this:
Screenshot from 2022-09-15 09-32-43

I don't think we can just allow notification to viewers that were already configured since it does not give us a path to remove a user when the need arises. Maybe this needs to be solved as part of FGAC?

Copy link
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 120 days.

@github-actions github-actions bot added the pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage pr:stale Added to a PR that has been deemed "stale". Managed by the actions/stale GitHub Action
Projects
None yet
Development

No branches or pull requests

3 participants