Incorrect Helm externalPostgresql.db_name parameter in values.yaml

[itay-grudev]

The Helm chart values.yaml refers to a parameter: externalPostgresql.db_name

oncall/helm/oncall/values.yaml

Lines 249 to 252 in ccbe825

	externalPostgresql:
	host:
	port:
	db_name:

Whereas the macro using the parameter is referring to just db (as in no _name).

oncall/helm/oncall/templates/_env.tpl

Lines 284 to 290 in 381520e

	{{- define "snippet.postgresql.db" -}}
	{{- if and (not .Values.postgresql.enabled) .Values.externalPostgresql.db -}}
	{{- required "externalPostgresql.db is required if not postgresql.enabled" .Values.externalPostgresql.db | quote}}
	{{- else -}}
	"oncall"
	{{- end -}}
	{{- end -}}

I suppose these need to be synced, likely in favour of the less descriptive db as it would not affect existing setups.

Unfortunately the typo was not made in the MariaDB which will cause an inconsistency:

oncall/helm/oncall/templates/_env.tpl

Lines 216 to 222 in 381520e

	{{- define "snippet.mysql.db" -}}
	{{- if and (not .Values.mariadb.enabled) .Values.externalMysql.db_name -}}
	{{- required "externalMysql.db is required if not mariadb.enabled" .Values.externalMysql.db_name | quote}}
	{{- else -}}
	"oncall"
	{{- end -}}
	{{- end -}}