Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fluent-bit also in addition/replacement for fluentd #770

Closed
rverma-nikiai opened this issue Jul 17, 2019 · 8 comments
Closed

Support fluent-bit also in addition/replacement for fluentd #770

rverma-nikiai opened this issue Jul 17, 2019 · 8 comments
Labels
component/agent component/integrations help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale. type/feature Something new we should do

Comments

@rverma-nikiai
Copy link

rverma-nikiai commented Jul 17, 2019

Is your feature request related to a problem? Please describe.
Fluentd is still a resource hoggy service, also multiple elk/splunk etc consumers prefers fluent-bit.

Describe the solution you'd like
We should support fluent-bit also, there is some initial work as well https://github.com/cosmo0920/fluent-bit-go-loki
Additionally, fluent-bit native support for kubernetes allows gathering all labels/annotations by default.

Can we manage this officially at https://github.com/fluent/fluent-bit/tree/master/plugins

@cyriltovena cyriltovena added component/agent component/integrations help wanted We would love help on these issues. Please come help us! type/feature Something new we should do labels Jul 17, 2019
@cyriltovena
Copy link
Contributor

A big yes !

@cyriltovena
Copy link
Contributor

@cosmo0920 would you be interested into merging this into our repository ?

@cosmo0920
Copy link
Contributor

cosmo0920 commented Aug 2, 2019

Yeah. I'm interested in merging my fluent-bit go loki plugin here.

But, I have questions to start to work:

  • How do I manage fluent-bit-go-loki plugin's library dependencies?
  • I want to continue to improve fluent-bit-go-loki plugin (most of my hobby work, not Fluentd/fluent-bit contributor work). How should I support to improvement here?
  • Need to rectify loki's main Makefile for this work?

@cyriltovena
Copy link
Contributor

cyriltovena commented Aug 2, 2019

I think the ultimate goal will be to have an official plugin in the fluentbit repository. But let's fist incubate a version here. I'll get in touch with the fluentbit team see how that would work. I'm not sure if the a go version can become official. Looks like most officials one are written in C.

How do I manage fluent-bit-go-loki plugin's library dependencies?

Right now we use dep. You can create a new cmd/fluent-bit folder.

How should I support to improvement here?

You would still be able to contribute here, though you would need review first by us. However I'm working on a governance document and you could become a member of this Repository. You would still need review that how we manage this repo. Basically decisions will be taken together as a team.

Need to rectify loki's main Makefile for this work?

Yes and we're here to help you for this. I think you should not worry too much about this for now, let's start step by step. I think it would be easier to contribute one small PR at the time:

  • Fluentbit plugin code
  • documentation
  • Makefile & release.

@cosmo0920
Copy link
Contributor

I'll get in touch with the fluentbit team see how that would work. I'm not sure if the a go version can become official.

AFAIK, it must be written in C to become official fluent-bit plugin.
There is no exception for this.

@cyriltovena
Copy link
Contributor

Fair enough.

@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 3, 2019
@cyriltovena cyriltovena added the keepalive An issue or PR that will be kept alive and never marked as stale. label Sep 3, 2019
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Sep 3, 2019
@cyriltovena
Copy link
Contributor

cyriltovena commented Sep 26, 2019

Fixed by #847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/agent component/integrations help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale. type/feature Something new we should do
Projects
None yet
Development

No branches or pull requests

3 participants