Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go4.org/unsafe/assume-no-moving-gc dependency to support Go 1.18 #5875

Closed
hdecarne opened this issue Apr 12, 2022 · 3 comments · Fixed by #6046
Closed

Update go4.org/unsafe/assume-no-moving-gc dependency to support Go 1.18 #5875

hdecarne opened this issue Apr 12, 2022 · 3 comments · Fixed by #6046
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code

Comments

@hdecarne
Copy link

Describe the bug
After building Loki using Go 1.18 it panics at start as follows:

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.18 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.18 set. Notably, if go1.18 adds a moving garbage collector, this program is unsafe to use.

Latest version go4.org/unsafe/assume-no-moving-gc dependency considers Go 1.18 save (see commit)

To Reproduce
Steps to reproduce the behavior:

  1. Build Loki using Go 1.18
  2. Start Loki

Expected behavior
Loki starts

Environment:
Custom Loki build on Gentoo

@smijolovic
Copy link

Ran into this same issue. What's the new release timeframe?

@FTamas77
Copy link

Hi! I have the same issue. I imported "gorgonia.org/gorgonia" and that's all. Any help? Thanks

@periklis
Copy link
Collaborator

You maybe interested to solve it like we did in the operator code base #6748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants