Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul agent based service discovery for promtail #3744

Closed
trevorwhitney opened this issue May 18, 2021 · 2 comments · Fixed by #3834
Closed

consul agent based service discovery for promtail #3744

trevorwhitney opened this issue May 18, 2021 · 2 comments · Fixed by #3834
Assignees

Comments

@trevorwhitney
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The current service discovery mechanism for consul relies on the consul catalog api. This is problematic for very large clusters. Since promtail is often co-located with jobs on a machine also running a local consul agent, it would be nice to have the option to use the agent api instead. This would result in much smaller payloads when discovering services in large clusters.

Describe the solution you'd like
Either as a separate service discovery mechanism, or a configuration option to the existing consul service discovery mechanism, consul service discovery can be instructed to use the consul agent api for service discovery as opposed to the consul catalog api.

Describe alternatives you've considered

  1. Use the current catalog api based SD as it exists:
  • This results in json payload sizes of 300MB+ for the large cluster in question, causing the SD to struggle to keep up.

Additional context
This solution in particular is for a Nomad cluster. Nomad also has an API that could be leveraged for SD, but it appears to return results for the whole cluster (similar to the consul catalog API) and thus would likely run into the same scaling problems.

@trevorwhitney
Copy link
Collaborator Author

My team and I are volunteering to work on this, but wanted to expose the issue first to gather opinions/feedback.

@trevorwhitney trevorwhitney self-assigned this May 18, 2021
@owen-d
Copy link
Member

owen-d commented May 19, 2021

This sounds reasonable to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants