Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply request length limit to label and series queries. #1747

Closed
cyriltovena opened this issue Feb 26, 2020 · 1 comment · Fixed by #2572
Closed

Apply request length limit to label and series queries. #1747

cyriltovena opened this issue Feb 26, 2020 · 1 comment · Fixed by #2572
Assignees
@adityacs
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved

Comments

@cyriltovena
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently max_query_length limits is only apply to query_range.

Describe the solution you'd like
We should apply this limit to labels and series API too.
@cyriltovena cyriltovena added component/loki type/enhancement Something existing could be improved keepalive An issue or PR that will be kept alive and never marked as stale. labels Feb 26, 2020
@slim-bean
Copy link
Collaborator

@adityacs ping me and we can chat about this!

@adityacs adityacs mentioned this issue Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityacs adityacs

Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate max_query_length in Labels API adityacs/loki
3 participants
@cyriltovena @adityacs @slim-bean