Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request start and end inclusivity/exclusivity #1570

Closed
cyriltovena opened this issue Jan 23, 2020 · 2 comments
Closed

Request start and end inclusivity/exclusivity #1570

cyriltovena opened this issue Jan 23, 2020 · 2 comments
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented Jan 23, 2020

Describe the bug
It seems that the start is not inclusive anymore from this discussion #597 (comment)

We should have the start inclusive and end exclusive for log query requests and also add this as part of the API documentation. The precision should be nanoseconds.

To Reproduce
see discussion

Expected behavior
the start inclusive and end exclusive, at least that how it was before.

/cc @aocenas can you add commit information where you found this please.

@cyriltovena cyriltovena added component/loki keepalive An issue or PR that will be kept alive and never marked as stale. labels Jan 23, 2020
@aocenas
Copy link
Member

aocenas commented Jan 24, 2020

Hey @cyriltovena sorry my bad, I thought I was some newer master but seems like I did not pull for quite some time, now testing it on 1.3.0 and seems like this works as expected. Going to close this now, will test on master and reopen if I see this again.

@aocenas aocenas closed this as completed Jan 24, 2020
@cyriltovena
Copy link
Contributor Author

Out of curiosity on which sha were you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Development

No branches or pull requests

2 participants