Build is failing on Linux

[amotl]

Hi there,

coming from #22, @gowrisankar22 found build problems like

fsevents@1.2.4: The platform "Linux" is incompatible with this module

While we related this to some Docker quirks on the first hand as building on a vanilla Debian Linux wasn't a problem for us the other day, @davkal confirmed that

building the plugin on linux is currently failing

Bummer! We will give this a short investigation to find out why this might happen.

Cheers,
Andreas.

[amotl]

Hi again,

we can confirm the behavior with current master. However, after finding the appropriate hint with yarnpkg/yarn#2051 (comment) and removing the offending lines in package.json:

diff --git a/package.json b/package.json
index 9296f3b..1734d09 100644
--- a/package.json
+++ b/package.json
@@ -58,9 +58,5 @@
     "typescript": "^2.8.3",
     "webpack": "4.28.4",
     "webpack-cli": "3.2.1"
-  },
-  "resolutions": {
-    "jest/jest-cli/jest-haste-map/sane/fsevents": "1.2.4",
-    "webpack/watchpack/chokidar/fsevents": "1.2.4"
   }
 }

yarn install and the subsequent yarn dev seem to work flawlessly. Maybe you would consider that change as an additional amendment when there are no objections about it.

With kind regards,
Andreas.

[davkal]

Thanks a lot for investigating this. Those lines were added so it builds under Mac with node v11.6.0. Perhaps they are no longer needed. Will investigate.

[davkal]

@briangann are you on Linux?

[briangann]

i'm on mac, but those lines are not needed for mac either. i thought we removed them, must have left out that commit

[daniellee]

@amotl this should be fixed in the latest master now

[briangann]

please verify this is working now

[amotl]

please verify this is working now

It works like a charm. Thanks!

cc @daniellee and @briangann