Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular usable in browser developer tools despite config flag is set to false. #61747

Closed
GregorLaber opened this issue Jan 19, 2023 · 1 comment · Fixed by #65755
Closed

Angular usable in browser developer tools despite config flag is set to false. #61747

GregorLaber opened this issue Jan 19, 2023 · 1 comment · Fixed by #65755

Comments

@GregorLaber
Copy link

What happened:
I upgraded my Grafana version from 9.2.6 to 9.3.1 and unlike before, Angular keywords are now possible again in my browser's developer tools (see Screenshots). Although the config option "angular_support_enabled" is set to false.

What you expected to happen:
My expectation would be that even in a newer Grafana version Angular is not usable if this is disabled per config.

How to reproduce it (as minimally and precisely as possible):
docker run -d -p 3000:3000 -v $PWD/etc/grafana.ini:/etc/grafana/grafana.ini grafana/grafana:9.3.1

grafana.ini :
angular_support_enabled = false

Anything else we need to know?:
9.2.6:
image
9.3.1:
image

I have searched the documentation, community, release notes, changelogs etc. but have not found a change that plausibly explains this change in Grafana's behavior. If I have missed something, I would appreciate a message. Thanks in advance. 👋

Environment:

  • Grafana version: 9.3.1
  • Data source type & version: -
  • OS Grafana is installed on: Docker Image from Docker Hub
  • User OS & Browser: Ubuntu 22.04.1 LTS; Browser: 109.0 (64-bit) Mozilla Firefox
  • Grafana plugins: -
  • Others: Docker version 20.10.22
@tonypowa
Copy link
Contributor

hello @GregorLaber and thank you for creating this issue

i have reproduced the same from my end following your repro steps

image

forwarding this issue to the release engineering squad (note for the squad: please reroute if it does not belong)

@usmangt usmangt added area/docker triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced labels Jan 24, 2023
@JoaoSilvaGrafana JoaoSilvaGrafana added type/bug and removed triage/needs-confirmation used for OSS triage rotation - reported issue needs to be reproduced labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants