Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beyla: inform that CAP_NET_ADMIN is required #1221

Closed
mariomac opened this issue Oct 3, 2024 · 5 comments
Closed

Beyla: inform that CAP_NET_ADMIN is required #1221

mariomac opened this issue Oct 3, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@mariomac
Copy link
Contributor

mariomac commented Oct 3, 2024

In the error message that Beyla shows when some capabilities are missing, it is not currently showing that CAP_NET_ADMIN is required, as tc_ingress and tc_egress ebpf programs require that extra capability.

@rafaelroquetto
Copy link
Contributor

Because the bpf programs tc_ingress and tc_egress are part of ktracer, they are being unconditionally loaded. When fixing this issue, we need to make sure they are not loaded when cfg.EBPF.UseLinuxTC is set to false, as the loading of these programs is what requires CAP_NET_ADMIN.

@grcevski
Copy link
Contributor

grcevski commented Oct 7, 2024

Ah good catch @rafaelroquetto, I think we should add a separate issue to make sure we don't miss this part.

@marctc marctc added the documentation Improvements or additions to documentation label Nov 19, 2024
@grafsean
Copy link
Contributor

grafsean commented Feb 3, 2025

@mariomac have we improved the error message and now tell people that the capability is missing?

@grafsean grafsean self-assigned this Feb 3, 2025
@rafaelroquetto
Copy link
Contributor

@grafsean correct, we now display the error message citing CAP_NET_ADMIN when it's missing. We can close this issue if you want. This is the related PR: #1588

@grafsean
Copy link
Contributor

grafsean commented Feb 4, 2025

@rafaelroquetto and does this PR #1587 add the necessary documentation?

@marctc marctc closed this as completed Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants