Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add if condition to avoid the configuration missing check #1207

Closed
grcevski opened this issue Sep 27, 2024 · 1 comment · Fixed by #1208
Closed

Helm: Add if condition to avoid the configuration missing check #1207

grcevski opened this issue Sep 27, 2024 · 1 comment · Fixed by #1208

Comments

@grcevski
Copy link
Contributor

The following well intentioned check we have may conflict with dynamic configuration naming based on the helm version, e.g. <helm-release-name>-beyla:

{{- if and (not .Values.config.create) (eq .Values.config.name "") }}
  {{- fail "if .Values.config.name is not set, then .Values.config.create should be set to true to use default configuration" }}
{{- end }}

We should wrap this if/end with another if/end, something like if not skipConfigMapCheck which will avoid doing this check.

This is particularly useful when Beyla is deployed as part of another larger helm chart.

@grcevski
Copy link
Contributor Author

CC @petewall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant