Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push endpoint for jfr/pprof pyroscope/phlare protocol #395

Closed
tomershafir opened this issue Aug 6, 2023 · 3 comments
Closed

Add push endpoint for jfr/pprof pyroscope/phlare protocol #395

tomershafir opened this issue Aug 6, 2023 · 3 comments
Labels
enhancement New feature or request frozen-due-to-age

Comments

@tomershafir
Copy link

Request

Add push endpoint for jfr/pprof pyroscope/phlare protocol

Use case

Profiles are generally events and less fit the pull model like metrics (there are tradeoffs, of course). Thus, I think grafana agent should support the common case of user applying a push model with a jfr/pprof pyroscope/phlare endpoint, providing intermediate collector functions external to the data plane, with batching being a critical feature, and also filtering. I may be able to help contribute.

@tomershafir tomershafir added the enhancement New feature or request label Aug 6, 2023
@rfratto
Copy link
Member

rfratto commented Aug 15, 2023

cc @grafana/grafana-agent-profiling-maintainers WDYT?

@cyriltovena
Copy link

We are actually planning to do node wise profiling with async-profiler so no need to pull jfr.

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@ptodev
Copy link
Collaborator

ptodev commented Aug 21, 2024

Hi @tomershafir! Thank you for raising an issue. I'm going to close this one, because it seems to be a duplicate of #270.

@ptodev ptodev closed this as completed Aug 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age
Projects
No open projects
Development

No branches or pull requests

4 participants