Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The windows tests are only on release #6220

Closed
Tracked by #5564
freddyaboulton opened this issue Nov 1, 2023 · 1 comment · Fixed by #6380
Closed
Tracked by #5564

The windows tests are only on release #6220

freddyaboulton opened this issue Nov 1, 2023 · 1 comment · Fixed by #6380
Assignees
@pngwn
Labels
testing Related to testing and CI
Milestone
4.x

Comments

@freddyaboulton
Copy link
Collaborator

freddyaboulton commented Nov 1, 2023 •
edited
Loading

Coming from #5564 .

@pngwn and I talked about running the windows tests only on the release branch by changesets to speed up CI and reduce noise.
@freddyaboulton freddyaboulton mentioned this issue Nov 1, 2023
Closed
39 tasks
@freddyaboulton freddyaboulton added the testing Related to testing and CI label Nov 1, 2023
@freddyaboulton freddyaboulton added this to the 4.x milestone Nov 1, 2023
@abidlabs
Copy link
Member

abidlabs commented Nov 1, 2023 •
edited
Loading

Good idea. Also, the CI job for flaky Windows tests always passes, even when the tests themselves fail. Internal discussion.

@pngwn pngwn self-assigned this Nov 3, 2023
This was referenced Nov 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pngwn pngwn

Labels
testing Related to testing and CI
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

Makes the Windows tests only run on the release PR gradio-app/gradio
3 participants
@abidlabs @pngwn @freddyaboulton