fix: remove menu bar from about window (and others)

graasp · Jul 24, 2019 · 13d63ad · 13d63ad
1 parent 3a0a300
commit 13d63ad
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -20,6 +20,9 @@
     "type": "git",
     "url": "https://github.com/graasp/graasp-desktop"
   },
+  "bugs": {
+    "url": "https://github.com/graasp/graasp-desktop/issues"
+  },
   "scripts": {
     "dev": "yarn react-scripts start",
     "build": "env-cmd -f ./.env react-scripts build",

diff --git a/public/electron.js b/public/electron.js
@@ -160,6 +160,21 @@ const generateMenu = () => {
               icon_path: ICON_PATH,
               copyright: 'Copyright © 2019 React',
               product_name: PRODUCT_NAME,
+              use_version_info: false,
+              adjust_window_size: true,
+              win_options: {
+                parent: mainWindow,
+                resizable: false,
+                minimizable: false,
+                maximizable: false,
+                movable: true,
+                frame: true,
+              },
+              // ? automatically showing info from package.json is nice but not translated into different languages
+              // package_json_dir: path.join(__dirname, '../'),
+              // bug_link_text: 'Report a bug/issue',
+              // ? nor is a close button
+              // show_close_button: 'Close',
             });
           },
         },
@@ -228,7 +243,8 @@ const generateMenu = () => {
     },
   ];
 
-  Menu.setApplicationMenu(Menu.buildFromTemplate(template));
+  Menu.setApplicationMenu(null);
+  mainWindow.setMenu(Menu.buildFromTemplate(template));
 };
 
 app.on('ready', async () => {