Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix: some loaders to display data first and pagination bugs #967

Merged
merged 3 commits into from
Feb 5, 2024
Merged

fix: some loaders to display data first and pagination bugs #967

merged 3 commits into from
Feb 5, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jan 23, 2024 •
edited
Loading

In this PR:

  • move some loader logic to display data first (there is a lot more work to be done to make it really effective
  • fix some naming issues and pagination bugs that were set to zero

@spaenleh spaenleh force-pushed the update-table-height-and-move-loaders branch from 0943147 to 01dd152 Compare January 24, 2024 13:10
@spaenleh spaenleh changed the title fix: update table height and fix some loaders fix: some loaders to display data first and pagination bugs Jan 24, 2024
@spaenleh spaenleh self-assigned this Jan 26, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Jan 26, 2024
@spaenleh spaenleh force-pushed the update-table-height-and-move-loaders branch from 01dd152 to b8bd63b Compare January 29, 2024 14:52
@spaenleh spaenleh marked this pull request as ready for review January 29, 2024 14:52
ReidyT
ReidyT approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spaenleh spaenleh force-pushed the update-table-height-and-move-loaders branch from b8bd63b to 9d8d083 Compare January 31, 2024 08:37
pyphilia
pyphilia approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📒

@spaenleh spaenleh marked this pull request as draft February 2, 2024 09:30
@spaenleh spaenleh force-pushed the update-table-height-and-move-loaders branch from 9d8d083 to 38911c7 Compare February 5, 2024 06:39
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh marked this pull request as ready for review February 5, 2024 08:22
@spaenleh spaenleh merged commit 392a736 into main Feb 5, 2024
4 checks passed
@spaenleh spaenleh deleted the update-table-height-and-move-loaders branch February 5, 2024 12:28
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@ReidyT ReidyT ReidyT approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @ReidyT