Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

feat: refactor move modal, use accessible with pagination #951

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

pyphilia
Copy link
Contributor

From @LinaYahya good code base, I refactored the components of the move modal + use the accessible endpoint with a pagination

My focuses for the refactor were:

  • Create many components to avoid bloating
  • Have components as simple as possible (ie: breadcrumbs does not depend tree logic)
  • Reduce number of states (everything depends on selected id to move to, and selected item for navigation)
  • TreeModal is reusable (and does not depend on move logic)
  • Define better the breadcrumbs with fixed default values (root and "my graasp")
  • Add comments to help understanding

@LinaYahya take a look and let me know if you have questions, I'm far from being perfect but I hope you can learn from my code!

close #934

@pyphilia pyphilia self-assigned this Jan 12, 2024
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Nice !

@pyphilia pyphilia force-pushed the 934-move-modal-accessible branch from 0fe8da0 to 001d3e2 Compare January 15, 2024 11:41
@pyphilia pyphilia merged commit 1f18249 into main Jan 16, 2024
4 checks passed
@pyphilia pyphilia deleted the 934-move-modal-accessible branch January 16, 2024 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use /accessible for move modal
3 participants