Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

feat: filter memberships for same member to render highest permission only #936

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/components/item/sharing/ItemSharingTab.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import Typography from '@mui/material/Typography';
import {
DiscriminatedItem,
ItemMembership,
PermissionLevelCompare,
isPseudonymizedMember,
} from '@graasp/sdk';
import { Loader } from '@graasp/ui';
Expand All @@ -32,6 +33,27 @@ type Props = {
item: DiscriminatedItem;
memberships?: ItemMembership[];
};
interface PermissionMap {
[key: string]: ItemMembership;
}

const selectHighestMemberships = (
memberships: ItemMembership[],
): ItemMembership[] => {
const permissionMap = memberships.reduce<PermissionMap>((acc, curr) => {
const { member, permission } = curr;

if (
!acc[member.id] ||
PermissionLevelCompare.gt(permission, acc[member.id].permission)
) {
acc[member.id] = curr;
}
return acc;
}, {});

return Object.values(permissionMap);
};

const ItemSharingTab = ({ item, memberships }: Props): JSX.Element => {
const { t: translateBuilder } = useBuilderTranslation();
Expand Down Expand Up @@ -89,7 +111,7 @@ const ItemSharingTab = ({ item, memberships }: Props): JSX.Element => {
emptyMessage={translateBuilder(
BUILDER.SHARING_AUTHORIZED_MEMBERS_EMPTY_MESSAGE,
)}
memberships={authorizedMemberships}
memberships={selectHighestMemberships(authorizedMemberships)}
readOnly={!canEditSettings}
/>

Expand All @@ -104,7 +126,7 @@ const ItemSharingTab = ({ item, memberships }: Props): JSX.Element => {
</Typography>
<ItemMembershipsTable
item={item}
memberships={authenticatedMemberships}
memberships={selectHighestMemberships(authenticatedMemberships)}
emptyMessage={translateBuilder(
BUILDER.SHARING_AUTHENTICATED_MEMBERS_EMPTY_MESSAGE,
)}
Expand Down