Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

feat: add duplicate item action #932

Merged
merged 13 commits into from
Jan 23, 2024
Merged

feat: add duplicate item action #932

merged 13 commits into from
Jan 23, 2024

Conversation

LinaYahya
Copy link
Contributor

closes #449

@LinaYahya LinaYahya requested review from pyphilia and spaenleh January 9, 2024 09:45
@LinaYahya LinaYahya self-assigned this Jan 9, 2024
pyphilia
pyphilia suggested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! ☃️

@LinaYahya LinaYahya requested a review from pyphilia January 9, 2024 12:56
spaenleh
spaenleh suggested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🍸

Can we have one test for duplicating a root item and a test for duplicating an item inside a folder ?

@LinaYahya LinaYahya requested a review from spaenleh January 9, 2024 16:23
spaenleh
spaenleh suggested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation change. Can we have tests ?

@LinaYahya LinaYahya requested a review from spaenleh January 10, 2024 10:41
pyphilia
pyphilia suggested changes Jan 10, 2024
View reviewed changes
@LinaYahya LinaYahya requested a review from pyphilia January 11, 2024 10:23
spaenleh
spaenleh suggested changes Jan 15, 2024
View reviewed changes
pyphilia
pyphilia approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my comment for the tests is still relevant, otherwise all good for me.

@LinaYahya LinaYahya requested a review from spaenleh January 18, 2024 10:46
@spaenleh spaenleh changed the title feat: Add An item action to duplicate an item within the same folder feat: add duplicate item action Jan 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LinaYahya LinaYahya merged commit 175f173 into main Jan 23, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
@spaenleh spaenleh deleted the 449-duplicate-item branch February 14, 2024 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@spaenleh spaenleh spaenleh approved these changes

Assignees

@LinaYahya LinaYahya

Labels
v2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a Duplicate Action to Copy/Paste An Item in same folder
3 participants
@LinaYahya @pyphilia @spaenleh