This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
feat: display shared items #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancarlosfarah
suggested changes
Feb 3, 2021
| @@ -5,3 +5,5 @@ export const ERROR_CODE = 400; | |||
| export const SUCCESS_CODE = 200; | |||
|
|
|||
| export const parseStringToRegExp = (string) => string.replaceAll('?', '\\?'); | |||
|
|
|||
| export const EMAIL_FORMAT = '[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\\.[a-zA-Z0-9-.]+'; | |||
There was a problem hiding this comment.
Is this tested? Source? I always worry about these regexes.
There was a problem hiding this comment.
I can suppose that André has his own schemas and regexes already. Ideally I would like to use those, but for now I need simple checks for tests. And yes note that it is only used in tests.
There was a problem hiding this comment.
@ahgentil, do you have schemas to share?
There was a problem hiding this comment.
I'll merge this PR and create an issue to include schemas in the project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hagoptaminian @ahgentil @juancarlosfarah @hasanagh
close #16