Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix: fix edit modal content and navigation #1499

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Oct 3, 2024

This PR fixes two problems:

  • navigating from item root to child was not updating the parent. We removed the opti path that was unsync with itemId
  • we fixed the edit item modal content, by adding a useEffect. This is just some tape on the problem for now, we should refactor the full component. refactor edit modal client#629

@pyphilia pyphilia requested review from spaenleh and ReidyT October 3, 2024 14:34
@pyphilia pyphilia self-assigned this Oct 3, 2024
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛳️

@pyphilia pyphilia enabled auto-merge October 4, 2024 11:26
Copy link

sonarqubecloud bot commented Oct 7, 2024

@pyphilia pyphilia added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 13a053c Oct 7, 2024
4 checks passed
@spaenleh spaenleh deleted the 1497-fix-edit-modal-and-navigation branch October 14, 2024 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants