Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

feat(deps): migrate react query v5 #1446

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Sep 13, 2024

No description provided.

@ReidyT ReidyT force-pushed the 889-migrate-react-query-v5 branch 2 times, most recently from fd236e0 to 55a24de Compare September 17, 2024 09:44
@ReidyT ReidyT force-pushed the 889-migrate-react-query-v5 branch from 55a24de to aa214f0 Compare September 30, 2024 09:55
@ReidyT ReidyT requested review from pyphilia and spaenleh September 30, 2024 10:02
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Just out of curiosity, we do not need to change the usage of initialIsLoading ?

@ReidyT
Copy link
Contributor Author

ReidyT commented Sep 30, 2024

Looks good ! Just out of curiosity, we do not need to change the usage of initialIsLoading ?

No you're right, I forgot this! Thanks for your comment!

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥾

@ReidyT ReidyT force-pushed the 889-migrate-react-query-v5 branch from 380df2d to ca18f89 Compare October 2, 2024 09:21
Copy link

sonarqubecloud bot commented Oct 2, 2024

@ReidyT ReidyT added this pull request to the merge queue Oct 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@ReidyT ReidyT added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit dfd7197 Oct 2, 2024
4 checks passed
@pyphilia pyphilia deleted the 889-migrate-react-query-v5 branch October 2, 2024 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants