Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website: use shadow DOM to render DayPicker in the examples #1483

Closed
gpbl opened this issue Jul 15, 2022 · 0 comments · Fixed by #1498
Closed

website: use shadow DOM to render DayPicker in the examples #1483

gpbl opened this issue Jul 15, 2022 · 0 comments · Fixed by #1498
Assignees
@gpbl
Labels
docs Documentation only changes high This issue has a high priority

Comments

@gpbl
Copy link
Owner

gpbl commented Jul 15, 2022 •
edited
Loading

In the website we use Sandpack to render DayPicker because Docusaurus overrides the default style from DayPicker.

A workaround for this solution is to use shadow DOM (e.g. via https://www.npmjs.com/package/react-shadow) for a proper style encapsulation. This would provide an optimal testing environment when developing DayPicker.
@gpbl gpbl added high This issue has a high priority docs Documentation only changes labels Jul 15, 2022
@gpbl gpbl changed the title Docs: use shadow DOM to render DayPicker in the examples website: use shadow DOM to render DayPicker in the examples Jul 15, 2022
@gpbl gpbl mentioned this issue Jul 15, 2022
Merged
@gpbl gpbl self-assigned this Jul 16, 2022
@gpbl gpbl linked a pull request Aug 11, 2022 that will close this issue
website: improve layout for the examples #1498
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpbl gpbl

Labels
docs Documentation only changes high This issue has a high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

website: improve layout for the examples gpbl/react-day-picker
1 participant
@gpbl