HTML Filter with ^ has no effect

[theseer]

Based on the documentation for html-filters, the only syntactical difference to the cosmetic filters seems to be the ^-prefix.

It is my understanding that a match would remove the element specified from the html before the stream hits the rendering engine.

Yet, when adding a such a filter it does not seem to have any effect?
When omitting the ^-prefix, the element gets hidden as expected, so I assume the selector itself to be correct.

I'm not sure whether I'm doing something wrong and it's behaving as expected or this is a bug.

I tried this with my company website: https://thephp.cc/welcome with the following simple filter to hide respectively remove the Home link from the top menu bar.

The cosmetic filter thephp.cc##a:has-text(Home) works as expected, the a element gets hidden but remains in the dom. The html filter thephp.cc##^a:has-text(Home) though has no effect.

• OS/version: Fedora 27
• Browser/version: Firefox 58.0.2 (64-bit), Fedora build
• uBlock Origin version: v1.15.11b5, also tried 1.15.10 before

[gorhill]

Thanks for reporting.

There is an error in the regex I use to detect content type -- the error occurs when the document type is application/xhtml+xml.

However, once I fixed the error, this uncovered another issue with the HTML filtering code which occurrs as a result of parsing the XHTML document served at https://thephp.cc/welcome as a HTML one. So this needs fixing too.

[theseer]

That's what I call a quick fix. Thanks so much!

And also thanks for pointing out wrong mime type for our company website. Guess I have some fixing to do as well.

[gorhill]

Your mime type is fine, it's uBO which was not using it to pass to DOMParser, I was passing a hard coded text/html.

[ghost]

@gorhill problem is not fixed on youtube.com and duckduckgo.com

[gorhill]

I am not aware of any issue with HTML filtering on youtube.com and duckduckgo.com. If you uncovered an issue with uBO, open a new issue with all the needed details for others to reproduce as required. Also, be sure to read the documentation before so that you understand what exactly is HTML filtering.