From e360e90d1eaf7ff182486df83ea95a5f1b03558a Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Sun, 15 Nov 2020 10:19:09 -0500 Subject: [PATCH] Fix invalid support URL in document-blocked page Related issue: - https://github.com/uBlockOrigin/uBlock-issues/issues/1345 --- src/document-blocked.html | 12 ++++++------ src/js/document-blocked.js | 22 ++++++++++------------ 2 files changed, 16 insertions(+), 18 deletions(-) diff --git a/src/document-blocked.html b/src/document-blocked.html index fc3db9eab195b..87120c85a6d81 100644 --- a/src/document-blocked.html +++ b/src/document-blocked.html @@ -4,13 +4,13 @@ - - - - + + + + -
exclamation-triangle
+
exclamation-triangle

@@ -51,7 +51,7 @@ •   + -->
diff --git a/src/js/document-blocked.js b/src/js/document-blocked.js index 0bda0f99d6c7e..e89b030082b2e 100644 --- a/src/js/document-blocked.js +++ b/src/js/document-blocked.js @@ -60,19 +60,17 @@ let details = {}; const parent = uDom.nodeFromSelector('#whyex > span:nth-of-type(2)'); for ( const list of lists ) { - const elem = document.querySelector('#templates .filterList') - .cloneNode(true); - const source = elem.querySelector('.filterListSource'); - source.href += encodeURIComponent(list.assetKey); - source.textContent = list.title; - if ( - typeof list.supportURL === 'string' && - list.supportURL !== '' - ) { - elem.querySelector('.filterListSupport') - .setAttribute('href', list.supportURL); + const listElem = document.querySelector('#templates .filterList') + .cloneNode(true); + const sourceElem = listElem.querySelector('.filterListSource'); + sourceElem.href += encodeURIComponent(list.assetKey); + sourceElem.textContent = list.title; + if ( typeof list.supportURL === 'string' && list.supportURL !== '' ) { + const supportElem = listElem.querySelector('.filterListSupport'); + supportElem.setAttribute('href', list.supportURL); + supportElem.classList.remove('hidden'); } - parent.appendChild(elem); + parent.appendChild(listElem); } uDom.nodeFromId('whyex').style.removeProperty('display'); })();