Go 1.24 support

[stefanb]

While testing llgo with Go 1.24 release candidates in

• go 1.24.0, go@1.23 1.23.6 (new formula) Homebrew/homebrew-core#201070

there was a test error:

hello.go:1:1: package requires newer Go version go1.24 (application built with go1.23)
-: This application uses version go1.23 of the source-processing packages but runs version go1.24 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.

[cpunion]

It's not a bug - verified in PR #982

The error occurs because llgo was built with Go 1.23 but is running with Go 1.24 when llgo calls go list. Just rebuild llgo with Go 1.24 and test again.

@stefanb Could you share the test?

[stefanb]

Hey, thanks for testing it.

The failing test is defined in:
https://github.com/Homebrew/homebrew-core/blob/6d1c476411e27bd62e7f6d37d9f204ef0567719f/Formula/l/llgo.rb#L63-L86

[cpunion]

Thanks. I guess llgo needs to be rebuilt after go is upgraded from 1.23 to 1.24. Is there a way to trigger an llgo rebuild automatically when go upgraded?

[stefanb]

We can bump revision in the same or a separate follow-up PR to publish a rebuilt bottle. Simillar as in govulncheck.rb in the same PR.

But in that test the llgo was already rebuilt (as well as all other formulae depending on go) and tests were run with newly rebuilt llgo and go 1.24rc3. Khm, unless the references to Formula["go"].opt_bin/"go" in test are using old go. 🤔

[cpunion]

Maybe let llgo depends on go@1.23, and create new revision after go 1.24 released into Homebrew?

[stefanb]

Homebrew cannot pin it yet to go@1.23 because this is the current formula at the moment.

llgo is currently on the list in Homebrew/homebrew-core#201070 with a link to this issue, to be checked immediately after go 1.24 formula is merged. Options in order of preference are:

• bump llgo formula revision to rebuild it with Go 1.24
• pin llgo to go@1.23

[cpunion]

@stefanb So currently we don't need to do anything, just follow the Go 1.24 progress?

[stefanb]

Correct. If you tested it with go 1.24 rc it should be easy to do a follow-up in homebrew.

[stefanb]

Indeed, rebuilding in Homebrew/homebrew-core#207420 was enough, thank you!

[cpunion]

@stefanb Thanks.