Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go SDK] Remove boolean returned from relevant Counters and Lists methods #3737

Closed
markmandel opened this issue Mar 27, 2024 · 2 comments · Fixed by #3738
Closed

[Go SDK] Remove boolean returned from relevant Counters and Lists methods #3737

markmandel opened this issue Mar 27, 2024 · 2 comments · Fixed by #3738
Labels
kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@markmandel
Copy link
Collaborator

markmandel commented Mar 27, 2024

I think the only case of this is in the Go SDK, but writing this in case I missed one.

https://pkg.go.dev/agones.dev/agones/sdks/go#Alpha.IncrementCounter - returns a (bool, error), make the return signature just error - the boolean isn't doing anything.

Also do the same on:

  • DecrementCounter
  • SetCounterCount,
  • SetCounterCapacity,
  • SetListCapacity,
  • AppendListValue,
  • DeleteListValue.

Thanks!

@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 27, 2024
@markmandel
Copy link
Collaborator Author

FYI: @igooch

@Kalaiselvi84 - might be another good task for you.

@markmandel
Copy link
Collaborator Author

Just saw this covered more than a few methods on the Go SDK, so edited with a list.

@markmandel markmandel added the kind/breaking Breaking change label Mar 27, 2024
@Kalaiselvi84 Kalaiselvi84 changed the title [Go SDK] Remove boolean returned from IncrementCounter and DecrementCounter [Go SDK] Remove boolean returned from relevant Counters and Lists methods Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant