Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag --incompatible_config_setting_private_default_visibility will break Cloud Robotics Core in Bazel 7.0 #94

Closed
keertk opened this issue Nov 23, 2022 · 2 comments
Assignees

Comments

@keertk
Copy link

keertk commented Nov 23, 2022

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking Cloud Robotics Core. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

@ensonic
Copy link
Contributor

ensonic commented Nov 24, 2022

bazel build --incompatible_config_setting_private_default_visibility //...
INFO: Analyzed 335 targets (1363 packages loaded, 23933 targets configured).
INFO: Found 335 targets...
INFO: Elapsed time: 52.304s, Critical Path: 38.31s
INFO: 41 processes: 1 internal, 40 linux-sandbox.
INFO: Build completed successfully, 41 total actions

@ensonic
Copy link
Contributor

ensonic commented Nov 25, 2022

Still fails du to another rule-package

(01:13:08) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/8f64c2da58aba524c96e00bc4efb6144/external/io_bazel_rules_go/BUILD.bazel:106:10: in go_config rule @io_bazel_rules_go//:go_config: target '@io_bazel_rules_go//go/private:stamp' is not visible from target '@io_bazel_rules_go//:go_config'. Check the visibility declaration of the former target if you think the dependency is legitimate
--
  | (01:13:08) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/8f64c2da58aba524c96e00bc4efb6144/external/io_bazel_rules_go/BUILD.bazel:106:10: Analysis of target '@io_bazel_rules_go//:go_config' failed
  | (01:13:08) ERROR: Analysis of target '//src/go/pkg/synk:go_default_test' failed; build aborted:


@ensonic ensonic reopened this Nov 25, 2022
@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break Cloud Robotics Core in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break Cloud Robotics Core in Bazel 7.0 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants