-
Notifications
You must be signed in to change notification settings - Fork 18
Document supported browser versions and protocols #32
Comments
Some sort of guidance regarding how production-ready the library is would also be useful. |
Ta for this, will hopefully take a look some point soon and tag you in any PRs |
@gauntface tag me too! :) |
I really like the idea of us including a compat table in the README like the one @ithinkihaveacat proposes. |
Additionally, a util that returns an ENUM by parsing navigator.userAgent will be handy. I'll raise a PR for this. |
@ameyakarve, I don't follow the use case for this util |
@gauntface So, if I were to implement support only for clients that support data-only pushes (which is much easier to maintain at the server side), it would be nice to have something that says whether that would be supported. I will probably be writing for work; I suppose others could find it useful too? |
@ameyakarve UA sniffing is not needed at all, and generally a bad practice. All of the different situations can be detected using feature detection. @ithinkihaveacat: |
@wibblymat Would you have snippets for that? Is it as simple as looking at what the subscription object returns or am I missing anything? |
examining the subscriptionfor the author key would be enough. For chrome you'll still need to check for gcm endpoint and change accordingly. |
It would be helpful to developers considering using this library if the README documented the browsers and protocols currently supported by the library, and the configurations that are expected to be supported in the future. (Maybe the version of Node, too.)
Something like:
Browsers in italics have not been released as of April 2016.
The text was updated successfully, but these errors were encountered: