Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Coordinate with web-push library #15

Open
marco-c opened this issue Mar 16, 2016 · 5 comments
Open

Coordinate with web-push library #15

marco-c opened this issue Mar 16, 2016 · 5 comments

Comments

@marco-c
Copy link

marco-c commented Mar 16, 2016

I'm the developer of https://github.com/marco-c/web-push, which is another server-side Node.js library for Web Push.
In my library, I've implemented push notifications for Firefox (with and without payloads) and Chrome (old GCM method, so without payload).
I'm planning to add support for payloads in Chrome (web-push-libs/web-push#114).

I'm also adding support for VAPID in Firefox (web-push-libs/web-push#112), and I'm looking forward to Chrome supporting it (https://bugs.chromium.org/p/chromium/issues/detail?id=583753).

I think the two libraries serve the same purpose, and we could merge them to avoid duplicating our efforts.

@wibblymat
Copy link
Contributor

Hi @marco-c! Sorry about not responding earlier. I failed to watch my own repo so didn't see this come in.

How exactly do you envisage merging working? We have similar libraries in other languages (go, java, etc.) in the works and would like to be able to talk about them as a collection once they are all released.

@marco-c
Copy link
Author

marco-c commented Mar 31, 2016

We could create a GitHub org where we put all the web push libraries (our merged Node.js one, @Minishlink PHP one, and the other ones we will eventually introduce in the future).

@marco-c
Copy link
Author

marco-c commented Apr 28, 2016

I assume you don't want to do this? Duplicating the work seems a waste of time to me, but I don't want to force you.

@marco-c marco-c closed this as completed Apr 28, 2016
@gauntface
Copy link
Contributor

Hey @marco-c that's totally not the case.

We've just been super swamped this side with all sorts going on.

Can we arrange a time to chat (either Hangouts, IRC, Slack, or .....?)

Cheers,
Matt

@gauntface gauntface reopened this May 6, 2016
@marco-c
Copy link
Author

marco-c commented May 10, 2016

Hey @gauntface, awesome! IRC would be great, what time works for you (I'm in London, UTC+1 now)? I'm marco in irc://irc.mozilla.org/push.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants