From d95bc9aef773da8ded4dd3132507fe596ee428ce Mon Sep 17 00:00:00 2001 From: BenWhitehead Date: Mon, 16 Aug 2021 18:06:18 -0400 Subject: [PATCH 1/2] fix: include code in the error response body --- testbench/error.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/testbench/error.py b/testbench/error.py index aee4c159..432eff88 100644 --- a/testbench/error.py +++ b/testbench/error.py @@ -29,7 +29,11 @@ def __init__(self, msg, code): self.code = code def as_response(self): - return flask.make_response(flask.jsonify(self.msg), self.code) + # Include both code and message so we follow the schema outlined in + # https://cloud.google.com/apis/design/errors#error_model and some + # clients depend on code being specified, otherwise behavior is + # undefined. + return flask.make_response(flask.jsonify(code=self.code, message=self.msg), self.code) @staticmethod def handler(ex): From b33ab9b9249dd2c0fdc04b69cb145f3aea705433 Mon Sep 17 00:00:00 2001 From: BenWhitehead Date: Mon, 16 Aug 2021 18:09:44 -0400 Subject: [PATCH 2/2] chore: format --- testbench/error.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/testbench/error.py b/testbench/error.py index 432eff88..5afe3228 100644 --- a/testbench/error.py +++ b/testbench/error.py @@ -33,7 +33,9 @@ def as_response(self): # https://cloud.google.com/apis/design/errors#error_model and some # clients depend on code being specified, otherwise behavior is # undefined. - return flask.make_response(flask.jsonify(code=self.code, message=self.msg), self.code) + return flask.make_response( + flask.jsonify(code=self.code, message=self.msg), self.code + ) @staticmethod def handler(ex):