Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubSub: Add more system tests covering various RBAC-related scenarios #8

Closed
plamut opened this issue Nov 22, 2019 · 0 comments · Fixed by #34
Closed

PubSub: Add more system tests covering various RBAC-related scenarios #8

plamut opened this issue Nov 22, 2019 · 0 comments · Fixed by #34
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. testing type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Nov 22, 2019

A regression introduced not so long ago could have been prevented if we had more RBAC-related system tests. A system test covering the fix was added in googleapis/google-cloud-python#9507.

Since PubSub backend defines several different user roles, system tests must be added to cover at least the most common use case scenarios that can be affected by the user role used in the session.
@plamut plamut self-assigned this Nov 30, 2019
@plamut plamut transferred this issue from googleapis/google-cloud-python Jan 31, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 31, 2020
@plamut plamut added type: process A process-related concern. May include testing, release, or the like. testing labels Jan 31, 2020
@yoshi-automation yoshi-automation removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 31, 2020
@plamut plamut mentioned this issue Feb 20, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add system tests for common RBAC operations plamut/python-pubsub
2 participants
@plamut @yoshi-automation