Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to have more control over the MIN_ACK_DEADLINE value #455

Closed
plamut opened this issue Jul 20, 2021 · 1 comment
Closed

Allow users to have more control over the MIN_ACK_DEADLINE value #455

plamut opened this issue Jul 20, 2021 · 1 comment
Assignees
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@plamut
Copy link
Contributor

plamut commented Jul 20, 2021

Context: This comment and the discussion that followed.

A user would like to set an initial streaming pull ACK deadline to a custom value, but we currently use MIN_ACK_DEADLINE. We should allow the user to set that, subject to the constraint that it must fall into the [MIN_ACK_DEADLINE, MAX_ACK_DEADLINE] interval (we can gracefully adjust that, with possibly issuing a warning).

Quoting @kamalaboulhosn:

In the same way we have max_duration_per_lease_extension, we need min_duration_per_lease_extension

@plamut plamut added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 20, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jul 20, 2021
@kamalaboulhosn kamalaboulhosn self-assigned this Jul 22, 2021
@acocuzzo
Copy link
Contributor

acocuzzo commented Jul 6, 2022

This feature was added in Exactly once delivery changes

@acocuzzo acocuzzo closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants