Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate x-goog-request-params routing header #1004

Closed
daniel-sanche opened this issue Jul 26, 2024 · 1 comment · Fixed by #1005 or #1036
Closed

Duplicate x-goog-request-params routing header #1004

daniel-sanche opened this issue Jul 26, 2024 · 1 comment · Fixed by #1005 or #1036
Assignees
Labels
api: bigtable Issues related to the googleapis/python-bigtable API.

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Jul 26, 2024

The library uses _make_metadata to populate the x-goog-request-params metadata field. Later, the gapic layer automatically attaches its version of the same field. But the gapic-side doesn't touch app_profile_id

Both headers are sent to the backend, which can cause issues with routing

We can resolve this by making a patch in the gapic_generator

@daniel-sanche daniel-sanche self-assigned this Jul 26, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jul 26, 2024
@daniel-sanche daniel-sanche reopened this Oct 31, 2024
@daniel-sanche
Copy link
Contributor Author

Re-opening this. After trying to fix this at the gapic-generator level, it looks like we need to make some fixes back at the bigtable level. Context here: googleapis/gapic-generator-python#2078 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API.
Projects
None yet
1 participant