Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

AutoML tables: changing just a col's data type apparently also changes the nullability status #2

Closed
amygdala opened this issue Jan 17, 2020 · 5 comments
Assignees
Labels
api: automl Issues related to the googleapis/python-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@amygdala
Copy link
Contributor

With the automl tables client libs, I'm seeing that a call like this to change the data type of a column, where that column is initially set to be Nullable:

client.update_column_spec(
          dataset_display_name='my dataset',
          column_spec_display_name='col_name',
          type_code='CATEGORY')

also changes the nullability-- it changes the col to from nullable to non-nullable.

(I haven't tried the case where the col starts out as non-nullable).

(The wrapper code looks okay on the face of it... )

@amygdala
Copy link
Contributor Author

Explicitly setting nullable=True in the call does the right thing, so I'm guessing it's a False vs None logic error somewhere.

@helinwang helinwang self-assigned this Jan 17, 2020
@helinwang
Copy link
Contributor

Thanks for finding the issue Amy! Seems the problem is the code did not use update_mask. So the nullable field is overridden with the proto default value (False). I will send a fix for it.

@busunkim96 busunkim96 transferred this issue from googleapis/google-cloud-python Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 31, 2020
@busunkim96 busunkim96 added api: automl Issues related to the googleapis/python-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Apr 30, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jul 15, 2020
@munkhuushmgl munkhuushmgl added type: process A process-related concern. May include testing, release, or the like. and removed 🚨 This issue needs some love. labels Jul 30, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jul 30, 2020
@munkhuushmgl
Copy link
Contributor

@helinwang Hey is there any update or internal bug logged somewhere?

@munkhuushmgl munkhuushmgl removed the 🚨 This issue needs some love. label Aug 7, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Aug 7, 2020
@amygdala
Copy link
Contributor Author

amygdala commented Aug 7, 2020

b/148677380

@munkhuushmgl munkhuushmgl removed the 🚨 This issue needs some love. label Aug 19, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Aug 19, 2020
@munkhuushmgl munkhuushmgl removed 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 23, 2020
@kweinmeister
Copy link
Contributor

Closing this issue for now, but please reopen if you are seeing this behavior.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: automl Issues related to the googleapis/python-automl API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

6 participants