From 8a4ae5b07712588bd0deae917d9e17f34f1ebb60 Mon Sep 17 00:00:00 2001 From: Tom Andersen Date: Thu, 9 Nov 2023 11:54:49 -0500 Subject: [PATCH] fix: Remove temporary header encoding workaround (#1935) * fix: Remove header encoding workaround * remove unused import --- dev/src/index.ts | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/dev/src/index.ts b/dev/src/index.ts index 1a95d689b..e797669b3 100644 --- a/dev/src/index.ts +++ b/dev/src/index.ts @@ -84,7 +84,6 @@ import { RECURSIVE_DELETE_MIN_PENDING_OPS, RecursiveDelete, } from './recursive-delete'; -import {stringify} from 'querystring'; export { CollectionReference, @@ -593,21 +592,6 @@ export class Firestore implements firestore.Firestore { } } - // TODO (multi-db) Revert this override of gax.routingHeader.fromParams - // after a permanent fix is applied. See b/292075646 - // This override of the routingHeader.fromParams does not - // encode forward slash characters. This is a temporary fix for b/291780066 - gax.routingHeader.fromParams = params => { - return stringify(params, undefined, undefined, { - encodeURIComponent: (val: string) => { - return val - .split('/') - .map(component => encodeURIComponent(component)) - .join('/'); - }, - }); - }; - if (this._settings.ssl === false) { const grpcModule = this._settings.grpc ?? require('google-gax').grpc; const sslCreds = grpcModule.credentials.createInsecure();