Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Zone: Reuse CreateChange types for convenience methods #132

Closed
carnesen opened this issue Oct 12, 2018 · 0 comments
Closed

Zone: Reuse CreateChange types for convenience methods #132

carnesen opened this issue Oct 12, 2018 · 0 comments
Assignees
Labels
api: dns Issues related to the googleapis/nodejs-dns API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@carnesen
Copy link
Contributor

There are currently several new types defined in Zone that are redundant with CreateChangeCallback and CreateChangeResponse. For example, addRecords is simply a thin wrapper around createChange

nodejs-dns/src/zone.ts

Lines 366 to 368 in 89623ec

addRecords(records: Record|Record[], callback: ZoneAddRecordsCallback) {
this.createChange({add: records}, callback);
}

For consistency and ease of maintenance, it would be better to make this relationship explicit in the typings by simply using the CreateChangeX types here.

@google-cloud-label-sync google-cloud-label-sync bot added the api: dns Issues related to the googleapis/nodejs-dns API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: dns Issues related to the googleapis/nodejs-dns API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants