diff --git a/.circleci/config.yml b/.circleci/config.yml index 8af6a4d04..da54155fc 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -68,8 +68,6 @@ jobs: environment: NPM_CONFIG_PREFIX: /home/node/.npm-global - run: npm test - - run: node_modules/.bin/codecov - node8: docker: - image: 'node:8' diff --git a/.kokoro/common.cfg b/.kokoro/common.cfg index 06c0c83f6..9c6ac80d8 100644 --- a/.kokoro/common.cfg +++ b/.kokoro/common.cfg @@ -13,6 +13,17 @@ gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline" # Use the trampoline script to run in docker. build_file: "nodejs-bigtable/.kokoro/trampoline.sh" +# Bring in codecov.io master token into the build as $KOKORO_KEYSTORE_DIR/73713_dpebot_codecov_token +before_action { + fetch_keystore { + keystore_resource { + keystore_config_id: 73713 + keyname: "dpebot_codecov_token" + backend_type: FASTCONFIGPUSH + } + } +} + # Configure the docker image for kokoro-trampoline. env_vars: { key: "TRAMPOLINE_IMAGE" diff --git a/.kokoro/test.bat b/.kokoro/test.bat index a8534ba80..d60473666 100644 --- a/.kokoro/test.bat +++ b/.kokoro/test.bat @@ -17,6 +17,8 @@ cd /d %~dp0 cd .. +call npm install -g npm@5 || goto :error + call npm install || goto :error call npm run test || goto :error diff --git a/.kokoro/test.sh b/.kokoro/test.sh index 51f29589b..eb25b89b9 100755 --- a/.kokoro/test.sh +++ b/.kokoro/test.sh @@ -22,4 +22,5 @@ cd $(dirname $0)/.. npm install npm test -node_modules/.bin/codecov + +bash $KOKORO_GFILE_DIR/codecov.sh diff --git a/codecov.yaml b/codecov.yaml new file mode 100644 index 000000000..5724ea947 --- /dev/null +++ b/codecov.yaml @@ -0,0 +1,4 @@ +--- +codecov: + ci: + - source.cloud.google.com diff --git a/package.json b/package.json index c28bbb40b..19d39da65 100644 --- a/package.json +++ b/package.json @@ -91,7 +91,7 @@ "eslint": "^5.0.0", "eslint-config-prettier": "^3.0.0", "eslint-plugin-node": "^7.0.0", - "eslint-plugin-prettier": "^2.3.1", + "eslint-plugin-prettier": "^3.0.0", "glob": "^7.1.2", "ink-docstrap": "^1.3.0", "intelli-espower-loader": "^1.0.1", diff --git a/src/instance.js b/src/instance.js index 5ab8765f5..6af30378c 100644 --- a/src/instance.js +++ b/src/instance.js @@ -609,7 +609,8 @@ Please use the format 'my-instance' or '${ * are 'name', 'schema' or 'full'. Default: 'name'. * @param {function} callback The callback function. * @param {?error} callback.err An error returned while making this request. - * @param {Table[]} callback.tables List of all Tables. + * @param {Table[]} callback.tables List of all Table objects.These objects contains + * only table name & id but is not a complete representation of a table. * @param {object} callback.apiResponse The full API response. * * @example include:samples/document-snippets/instance.js