Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for OLM Prefix/Suffix #1345

Closed
shaffeeullah opened this issue Apr 6, 2022 · 4 comments · Fixed by #1389
Closed

add support for OLM Prefix/Suffix #1345

shaffeeullah opened this issue Apr 6, 2022 · 4 comments · Fixed by #1389
Assignees
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shaffeeullah
Copy link

shaffeeullah commented Apr 6, 2022

We need to add support for the new LifecycleCondition field options matchesPrefix and matchesSuffix. Both of these will be a list of strings.

request (internal): go/prefix-suffix-client-library-request
nodejs-storage example: googleapis/nodejs-storage#1847

Please wait for my approval before merging/releasing this so we can coordinate around release dates.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 6, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 7, 2022
@BenWhitehead BenWhitehead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Apr 7, 2022
@sydney-munro sydney-munro self-assigned this Apr 20, 2022
@sydney-munro
Copy link
Contributor

did initial work for this and will push it to a branch, unfortunately we are blocked on part of the work until automated workflows push model updates to add matchesPrefix and matchesSuffix conditions. see here

@shaffeeullah
Copy link
Author

@sydney-munro is this still blocked?

@sydney-munro
Copy link
Contributor

sydney-munro commented May 12, 2022

I believe so the discovery doc has not seen updates and there are no PRs for a regeneration of the storage client with the updated conditions values linked above. I have been checking the status daily.

@sydney-munro
Copy link
Contributor

sydney-munro commented May 13, 2022

Discovery doc has been updated and the storage client code generation for the fields has been merged. this is now unblocked. Should be able to get a PR out either today or monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants