From 0e0fcfb93c628adc1f81b3b3c5cdcc97c6ea844e Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Sun, 20 Oct 2019 09:55:47 +0300 Subject: [PATCH 1/2] chore(bigquery): remove duplicate test dependencies --- bigquery/noxfile.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/bigquery/noxfile.py b/bigquery/noxfile.py index fc44db1c120e..fc9921163e4c 100644 --- a/bigquery/noxfile.py +++ b/bigquery/noxfile.py @@ -88,7 +88,6 @@ def system(session): for local_dep in LOCAL_DEPS: session.install("-e", local_dep) session.install("-e", os.path.join("..", "storage")) - session.install("-e", os.path.join("..", "test_utils")) session.install("-e", ".[all]") # IPython does not support Python 2 after version 5.x @@ -116,7 +115,6 @@ def snippets(session): for local_dep in LOCAL_DEPS: session.install("-e", local_dep) session.install("-e", os.path.join("..", "storage")) - session.install("-e", os.path.join("..", "test_utils")) session.install("-e", ".[all]") # Run py.test against the snippets tests. From 4322bd77b2bc4307bc2c3010cfa3278b177177bc Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Tue, 22 Oct 2019 22:52:34 +0300 Subject: [PATCH 2/2] Demote test_utils from LOCAL_DEPS in noxfile The test_utils dependency is only nedeed for test sessions, but not for some other nox sessions such as "lint" and "docs". --- bigquery/noxfile.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/bigquery/noxfile.py b/bigquery/noxfile.py index fc9921163e4c..a6d8094ebbc3 100644 --- a/bigquery/noxfile.py +++ b/bigquery/noxfile.py @@ -20,11 +20,7 @@ import nox -LOCAL_DEPS = ( - os.path.join("..", "api_core[grpc]"), - os.path.join("..", "core"), - os.path.join("..", "test_utils"), -) +LOCAL_DEPS = (os.path.join("..", "api_core[grpc]"), os.path.join("..", "core")) BLACK_PATHS = ("docs", "google", "samples", "tests", "noxfile.py", "setup.py") @@ -42,6 +38,7 @@ def default(session): for local_dep in LOCAL_DEPS: session.install("-e", local_dep) + session.install("-e", os.path.join("..", "test_utils")) dev_install = ".[all]" session.install("-e", dev_install) @@ -88,6 +85,7 @@ def system(session): for local_dep in LOCAL_DEPS: session.install("-e", local_dep) session.install("-e", os.path.join("..", "storage")) + session.install("-e", os.path.join("..", "test_utils")) session.install("-e", ".[all]") # IPython does not support Python 2 after version 5.x @@ -115,6 +113,7 @@ def snippets(session): for local_dep in LOCAL_DEPS: session.install("-e", local_dep) session.install("-e", os.path.join("..", "storage")) + session.install("-e", os.path.join("..", "test_utils")) session.install("-e", ".[all]") # Run py.test against the snippets tests.