Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system_test nox sessions shouldn't ALWAYS "pass" with no config #3248

Closed
dhermes opened this issue Mar 30, 2017 · 2 comments
Closed

system_test nox sessions shouldn't ALWAYS "pass" with no config #3248

dhermes opened this issue Mar 30, 2017 · 2 comments
Assignees
@lukesneeringer
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. testing

Comments

@dhermes
Copy link
Contributor

dhermes commented Mar 30, 2017

Was just chatting with @daspecster and running nox locally gives no real indication that the system tests did nothing.

Rather than checking for GOOGLE_APPLICATION_CREDENTIALS and saying "nothing to see here" we should probably instead do:

  1. Bail without failing if in CI and not in a push build (e.g.)
  2. If we've made it PAST the bail out (i.e. not on CI or in CI on a merge build) than FAIL THE TEST if GOOGLE_APPLICATION_CREDENTIALS is unset
@lukesneeringer
Copy link
Contributor

lukesneeringer commented Mar 30, 2017 •
edited
Loading

running nox locally gives no real indication that the system tests did nothing.

Running nox locally should run system tests. That is a bug. I will fix it.
Your list sounds correct.

@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Apr 4, 2017
@lukesneeringer
Copy link
Contributor

Superceded by #3475.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukesneeringer lukesneeringer

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukesneeringer @dhermes